Wikia

WoWWiki

Talk:WoWBench/To do

102,255pages on
this wiki

Back to page | < Talk:WoWBench

  Icon-edit-22x22 Start a new discussion!    

Request for math.sqrt Edit

Hey Tarog.. I don't get it ... Lua has math.sqrt by default? (btw you got my mail right?) --Mikk 11:31, 16 June 2006 (EDT)

C:\wow\wowbench\trunk>lua50
Lua 5.0.2  Copyright (C) 1994-2004 Tecgraf, PUC-Rio
> print(math.sqrt(4));
2

I should have been more clear. 'sqrt' (which WoW uses) hasn't been implemented like all the other math functions. Just a matter of adding sqrt = math.sqrt in api.lua . Much of blizzard's UI uses just 'sqrt' and not 'math.sqrt' so I thought it necessary to post that. --Tarog 11:54, 16 June 2006 (EDT)

Ahh doh. I need more coffee. Fixing. --Mikk 11:57, 16 June 2006 (EDT)

Oh, and I did get your mail, just replied :) --Tarog 12:09, 16 June 2006 (EDT)

api.lua thoughts Edit

From the looks of it it doesn't quite seem like you decided how you wanted to organize the functions in api.lua. I think our best bet would be just alphabetizing them, just for the sake of making them easy to find for future comparison and readability. We would place the WOWB_CVarDefaults at the top along with the WoWified lua functions and any constants, then placing all the API functions after that alphabetized.
Also I'm not liking how the comments are working out in api.lua.

function HasKey() return false; end  -- [DUD] Added in 1.11

I like the idea behind the tags and I think there should be something like that, but the way you are currently doing comments will get really messy fast. Possibly something like the following?

-- HasKey() [DUD] Added in 1.11 --
function HasKey() return false; end
-- CanShowResetInstances() [DUD] Added in 1.11 --
function CanShowResetInstances() return false; end

We don't even necessarily need the "Added in 1.11" stuff I don't think.
I dunno, just throwing out ideas. I'm just not fond of the current commenting scheme.
--Tarog 17:09, 16 June 2006 (EDT)

No, I never really did try to organize api.lua. I just chugged away at functions as I needed them. I agree wholeheartedly with all of your ideas. --Mikk 17:40, 16 June 2006 (EDT)
I'll work on reformatting the api.lua tonight then, if you don't have any objections. --Tarog 17:46, 16 June 2006 (EDT)
Feel free =) I can write up the parser tomorrow morning. I'm fairly fluent at text parsing crud. --Mikk 20:03, 16 June 2006 (EDT)

wowbench_start.bat Edit

I realised that I cba to load up wowbench every time so i just quickly made a little batch file that will open up wowbench for you. Note: this does NOT install it, just open it after you have already installed it and set it up. [1] at the moment it is just a patch waiting to be approved to be included into the standard wowbench build

-- EKJ (talk) 15:35, 23 September 2008 (UTC)

Around Wikia's network

Random Wiki